code review 8008043: net: disable tests with controlling network facilities ...

net: disable tests with controlling network facilities in short mode

Perhaps it would make FreeBSD 10-CURRENT/ARM on Raspberry Pi builders happy.

[mikio, 2013-03-25 03:14:21]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-03-25 03:21:50]

I think the test is failing because this kernel does not support gif
interface types. That is a guess because we don't see the full command
that is executed.

I'd be happier seeing the test disabled on GOOS=freebsd, GOARCH=arm

On Mon, Mar 25, 2013 at 2:14 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: disable tests with controlling network facilities in short mode
>
> Perhaps it would make FreeBSD 10-CURRENT/ARM on Raspberry Pi builders
> happy.
>
> Please review this at https://codereview.appspot.com/8008043/
>
> Affected files:
>   M src/pkg/net/interface_unix_test.go
>
>
> Index: src/pkg/net/interface_unix_test.go
> ===================================================================
> --- a/src/pkg/net/interface_unix_test.go
> +++ b/src/pkg/net/interface_unix_test.go
> @@ -41,8 +41,11 @@
>  }
>
>  func TestPointToPointInterface(t *testing.T) {
> -       switch runtime.GOOS {
> -       case "darwin":
> +       if testing.Short() {
> +               t.Skip("skipping test in short mode")
> +       }
> +       switch {
> +       case runtime.GOOS == "darwin":
>                 t.Skipf("skipping read test on %q", runtime.GOOS)
>         }
>         if os.Getuid() != 0 {
> @@ -90,6 +93,9 @@
>  }
>
>  func TestInterfaceArrivalAndDeparture(t *testing.T) {
> +       if testing.Short() {
> +               t.Skip("skipping test in short mode")
> +       }
>         if os.Getuid() != 0 {
>                 t.Skip("skipping test; must be root")
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[mikio, 2013-03-25 04:04:27]

The tests are optional, non-critical the same as tests in
unicast_posix_test.go do and I think it's not necessary
to run in short mode.


On Mon, Mar 25, 2013 at 12:21 PM, Dave Cheney <dave@cheney.net> wrote:
> I think the test is failing because this kernel does not support gif
> interface types. That is a guess because we don't see the full command
> that is executed.
>
> I'd be happier seeing the test disabled on GOOS=freebsd, GOARCH=arm
>
> On Mon, Mar 25, 2013 at 2:14 PM,  <mikioh.mikioh@gmail.com> wrote:
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> net: disable tests with controlling network facilities in short mode
>>
>> Perhaps it would make FreeBSD 10-CURRENT/ARM on Raspberry Pi builders
>> happy.
>>
>> Please review this at https://codereview.appspot.com/8008043/
>>
>> Affected files:
>>   M src/pkg/net/interface_unix_test.go
>>
>>
>> Index: src/pkg/net/interface_unix_test.go
>> ===================================================================
>> --- a/src/pkg/net/interface_unix_test.go
>> +++ b/src/pkg/net/interface_unix_test.go
>> @@ -41,8 +41,11 @@
>>  }
>>
>>  func TestPointToPointInterface(t *testing.T) {
>> -       switch runtime.GOOS {
>> -       case "darwin":
>> +       if testing.Short() {
>> +               t.Skip("skipping test in short mode")
>> +       }
>> +       switch {
>> +       case runtime.GOOS == "darwin":
>>                 t.Skipf("skipping read test on %q", runtime.GOOS)
>>         }
>>         if os.Getuid() != 0 {
>> @@ -90,6 +93,9 @@
>>  }
>>
>>  func TestInterfaceArrivalAndDeparture(t *testing.T) {
>> +       if testing.Short() {
>> +               t.Skip("skipping test in short mode")
>> +       }
>>         if os.Getuid() != 0 {
>>                 t.Skip("skipping test; must be root")
>>         }
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google Groups
>> "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>

[dave_cheney.net, 2013-03-25 04:05:36]

LGTM. Fair enough, let's see if it makes the freebsd/arm builder pass.

On Mon, Mar 25, 2013 at 3:04 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> The tests are optional, non-critical the same as tests in
> unicast_posix_test.go do and I think it's not necessary
> to run in short mode.
>
>
> On Mon, Mar 25, 2013 at 12:21 PM, Dave Cheney <dave@cheney.net> wrote:
>> I think the test is failing because this kernel does not support gif
>> interface types. That is a guess because we don't see the full command
>> that is executed.
>>
>> I'd be happier seeing the test disabled on GOOS=freebsd, GOARCH=arm
>>
>> On Mon, Mar 25, 2013 at 2:14 PM,  <mikioh.mikioh@gmail.com> wrote:
>>> Reviewers: golang-dev1,
>>>
>>> Message:
>>> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>>>
>>> I'd like you to review this change to
>>> https://code.google.com/p/go
>>>
>>>
>>> Description:
>>> net: disable tests with controlling network facilities in short mode
>>>
>>> Perhaps it would make FreeBSD 10-CURRENT/ARM on Raspberry Pi builders
>>> happy.
>>>
>>> Please review this at https://codereview.appspot.com/8008043/
>>>
>>> Affected files:
>>>   M src/pkg/net/interface_unix_test.go
>>>
>>>
>>> Index: src/pkg/net/interface_unix_test.go
>>> ===================================================================
>>> --- a/src/pkg/net/interface_unix_test.go
>>> +++ b/src/pkg/net/interface_unix_test.go
>>> @@ -41,8 +41,11 @@
>>>  }
>>>
>>>  func TestPointToPointInterface(t *testing.T) {
>>> -       switch runtime.GOOS {
>>> -       case "darwin":
>>> +       if testing.Short() {
>>> +               t.Skip("skipping test in short mode")
>>> +       }
>>> +       switch {
>>> +       case runtime.GOOS == "darwin":
>>>                 t.Skipf("skipping read test on %q", runtime.GOOS)
>>>         }
>>>         if os.Getuid() != 0 {
>>> @@ -90,6 +93,9 @@
>>>  }
>>>
>>>  func TestInterfaceArrivalAndDeparture(t *testing.T) {
>>> +       if testing.Short() {
>>> +               t.Skip("skipping test in short mode")
>>> +       }
>>>         if os.Getuid() != 0 {
>>>                 t.Skip("skipping test; must be root")
>>>         }
>>>
>>>
>>> --
>>>
>>> ---You received this message because you are subscribed to the Google
Groups
>>> "golang-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to golang-dev+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>>

[mikio, 2013-03-25 04:25:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=99a595ab951e ***

net: disable tests with controlling network facilities in short mode

Perhaps it would make FreeBSD 10-CURRENT/ARM on Raspberry Pi builders happy.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/8008043