Issue 8003046: code review 8003046: math: make Hypot special cases look like others

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8003046: code review 8003046: math: make Hypot special cases look like others (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

math: make Hypot special cases look like others The edit makes Hypot's description match the form used in the other routines in this package.

Patch Set 1 #

Patch Set 2 : diff -r 2334cbe0190b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2334cbe0190b https://code.google.com/p/go/ #

Patch Set 4 : diff -r f0a9210fdd8c https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/math/hypot.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-25 20:20:16 UTC) #1

rsc

12 years ago (2013-03-25 21:01:47 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b3cfb8be2faf ***

math: make Hypot special cases look like others

The edit makes Hypot's description match the form
used in the other routines in this package.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/8003046

Expand All Messages | Collapse All Messages