Issue 800042: code review 800042: single argument panic on non-darwin and in comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 800042: code review 800042: single argument panic on non-darwin and in comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

single argument panic on non-darwin and in comments

Patch Set 2 : code review 800042: single argument panic on non-darwin and in comments #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	src/pkg/debug/proc/proc_linux.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/debug/proc/regs_linux_386.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/debug/proc/regs_linux_amd64.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/syscall_mingw.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/websocket/client.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/websocket/server.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-30 20:03:58 UTC) #1

LGTM http://codereview.appspot.com/800042/diff/1/6 File src/pkg/syscall/zerrors_linux_386.go (left): http://codereview.appspot.com/800042/diff/1/6#oldcode1 src/pkg/syscall/zerrors_linux_386.go:1: // mkerrors.sh i don't understand why this file ...

15 years ago (2010-03-30 20:10:46 UTC) #2

rsc

15 years ago (2010-03-30 20:15:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=7afea75128a6 ***

single argument panic on non-darwin and in comments

R=r
CC=golang-dev
http://codereview.appspot.com/800042

Expand All Messages | Collapse All Messages