code review 7992044: builtin: add linkable-to declarations for iota and nil

builtin: add linkable-to declarations for iota and nil
Aids godoc.

[r, 2013-03-26 17:53:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-03-26 17:55:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2013-03-26 17:58:43]

LGTM

https://codereview.appspot.com/7992044/diff/1/src/pkg/builtin/builtin.go
File src/pkg/builtin/builtin.go (right):

https://codereview.appspot.com/7992044/diff/1/src/pkg/builtin/builtin.go#newc...
src/pkg/builtin/builtin.go:89: // ordinal number of the current declaration in a
(usually parenthesized)
... of the current constant specification in a (usually parenthesized) const
declaration.


(or perhaps: "... constant declaration." instead of "const declaration").

This is closer to the nomenclature used in the spec.

[bradfitz, 2013-03-26 18:03:25]

I wouldn't mind links to the spec on more of these.

On Tue, Mar 26, 2013 at 10:53 AM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> builtin: add linkable-to declarations for iota and nil
> Aids godoc.
>
> Please review this at
https://codereview.appspot.**com/7992044/<https://codereview.appspot.com/7992...
>
> Affected files:
>   M src/pkg/builtin/builtin.go
>
>
> Index: src/pkg/builtin/builtin.go
> ==============================**==============================**=======
> --- a/src/pkg/builtin/builtin.go
> +++ b/src/pkg/builtin/builtin.go
> @@ -85,6 +85,15 @@
>  // used, by convention, to distinguish character values from integer
> values.
>  type rune rune
>
> +// iota is a predeclared identifier representing the untyped integer
> +// ordinal number of the current declaration in a (usually parenthesized)
> +// const clause. It is zero-indexed.
> +const iota int // Untyped int.
> +
> +// nil is the predeclared identifier representing the zero value for a
> +// pointer, channel, func, interface, map, or slice type.
> +var nil Type // Type must be a pointer, channel, func, interface, map, or
> slice type
> +
>  // Type is here for the purposes of documentation only. It is a stand-in
>  // for any Go type, but represents the same type for any given function
>  // invocation.
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-03-26 18:05:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=e44cbac8211e ***

builtin: add linkable-to declarations for iota and nil
Aids godoc.

R=golang-dev, gri, bradfitz
CC=golang-dev
https://codereview.appspot.com/7992044

[r, 2013-03-26 18:05:33]

On Tue, Mar 26, 2013 at 11:03 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> I wouldn't mind links to the spec on more of these.

For another CL perhaps. They won't make the doc prettier.

-rob