Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2458)

Issue 7966043: code review 7966043: runtime: report at most 10 errors in netpoll (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dvyukov
Modified:
12 years ago
Reviewers:
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

runtime: does not report duplicate errors in netpoll Prevents storm of error messages if something goes wrong. In the case of issue 5073 the epoll fd was closed by the test. Update issue 5073.

Patch Set 1 #

Patch Set 2 : diff -r 9ca85035f95a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9ca85035f95a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 2be8c885acc8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r be1edd532f2d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/pkg/runtime/netpoll_epoll.c View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M src/pkg/runtime/netpoll_kqueue.c View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years ago (2013-03-22 08:20:25 UTC) #1
r
What other errors do you see? And does this mean the last one, the one ...
12 years ago (2013-03-22 15:19:26 UTC) #2
dvyukov
On Fri, Mar 22, 2013 at 7:19 PM, <r@golang.org> wrote: > What other errors do ...
12 years ago (2013-03-25 16:51:49 UTC) #3
rsc
sure
12 years ago (2013-03-25 22:03:08 UTC) #4
dvyukov
PTAL Now it does not report subsequent duplicate errors. In the case of issue 5073 ...
12 years ago (2013-03-26 07:23:43 UTC) #5
r
LGTM
12 years ago (2013-03-26 15:17:01 UTC) #6
dvyukov
12 years ago (2013-03-26 16:26:22 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=163d528e7436 ***

runtime: does not report duplicate errors in netpoll
Prevents storm of error messages if something goes wrong.
In the case of issue 5073 the epoll fd was closed by the test.
Update issue 5073.

R=golang-dev, r, rsc
CC=golang-dev
https://codereview.appspot.com/7966043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b