code review 7965043: cmd/5l, cmd/6l, cmd/8l: fix segfault on reading LOCALS ...

cmd/5l, cmd/6l, cmd/8l: fix segfault on reading LOCALS for a duplicate definition.

Fixes issue 5105.

[remyoudompheng, 2013-03-22 08:06:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2013-03-22 09:04:53]

LGTM. I can no longer reproduce the problem on my 10.7.5 system.

I wonder why this only affected darwin/amd64 ?

[remyoudompheng, 2013-03-22 09:32:33]

I could reproduce consistently  on linux/386 and linux/amd64

2013/3/22, dave@cheney.net <dave@cheney.net>:
> LGTM. I can no longer reproduce the problem on my 10.7.5 system.
>
> I wonder why this only affected darwin/amd64 ?
>
> https://codereview.appspot.com/7965043/
>

[dave_cheney.net, 2013-03-22 09:33:13]

Excellent. I'm glad we have a reliable test case in the test/ tree.

On Fri, Mar 22, 2013 at 8:32 PM, Rémy Oudompheng
<remyoudompheng@gmail.com> wrote:
> I could reproduce consistently  on linux/386 and linux/amd64
>
> 2013/3/22, dave@cheney.net <dave@cheney.net>:
>> LGTM. I can no longer reproduce the problem on my 10.7.5 system.
>>
>> I wonder why this only affected darwin/amd64 ?
>>
>> https://codereview.appspot.com/7965043/
>>

[DMorsing, 2013-03-22 09:48:51]

LGTM

[remyoudompheng, 2013-03-22 17:50:39]

Any opinion from rsc or cshapiro? The regression was introduced by
CL 7399045 :

changeset:   15842:ad69f53ba310
user:        Carl Shapiro <cshapiro@google.com>
date:        Thu Feb 21 12:52:26 2013 -0800
description:
cmd/5g, cmd/5l, cmd/6l, cmd/8l, cmd/gc, cmd/ld, runtime: accurate args and
locals information

[rsc, 2013-03-25 20:00:34]

LGTM

[remyoudompheng, 2013-03-25 21:10:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=2ac4f6f628f1 ***

cmd/5l, cmd/6l, cmd/8l: fix segfault on reading LOCALS for a duplicate
definition.

Fixes issue 5105.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/7965043