code review 7956044: misc/emacs: Derive mode from prog-mode if possible

misc/emacs: Derive mode from prog-mode if possible

[Dominik Honnef, 2013-03-23 23:42:21]

Hello golang-dev@googlegroups.com (cc: adonovan@google.com, cw@f00f.org,
patrick.allen.higgins@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-03-25 15:58:05]

LGTM

Nice comment.

On Sat, Mar 23, 2013 at 4:42 PM, <dominik.honnef@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: adonovan@google.com, cw@f00f.org,
> patrick.allen.higgins@gmail.**com <patrick.allen.higgins@gmail.com>),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/emacs: Derive mode from prog-mode if possible
>
> Please review this at
https://codereview.appspot.**com/7956044/<https://codereview.appspot.com/7956...
>
> Affected files:
>   M misc/emacs/go-mode.el
>
>
> Index: misc/emacs/go-mode.el
> ==============================**==============================**=======
> --- a/misc/emacs/go-mode.el
> +++ b/misc/emacs/go-mode.el
> @@ -52,6 +52,14 @@
>  (defun go--old-completion-list-style (list)
>    (mapcar (lambda (x) (cons x nil)) list))
>
> +;; GNU Emacs 24 has prog-mode, older GNU Emacs and XEmacs do not.
> +;; Ideally we'd use defalias instead, but that breaks in XEmacs.
> +;;
> +;; TODO: If XEmacs decides to add prog-mode, change this to use
> +;; defalias to alias prog-mode or fundamental-mode to go--prog-mode
> +;; and use that in define-derived-mode.
> +(if (not (fboundp 'prog-mode))
> +    (define-derived-mode prog-mode fundamental-mode "" ""))
>
>  (defun go--regexp-enclose-in-symbol (s)
>    ;; XEmacs does not support \_<, GNU Emacs does. In GNU Emacs we make
> @@ -370,7 +378,7 @@
>        (forward-char))))
>
>  ;;;###autoload
> -(define-derived-mode go-mode fundamental-mode "Go"
> +(define-derived-mode go-mode prog-mode "Go"
>    "Major mode for editing Go source text.
>
>  This mode provides (not just) basic editing capabilities for
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[bradfitz, 2013-03-25 15:58:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=f78c5036b7f6 ***

misc/emacs: Derive mode from prog-mode if possible

R=golang-dev, bradfitz
CC=adonovan, cw, golang-dev, patrick.allen.higgins
https://codereview.appspot.com/7956044

Committer: Brad Fitzpatrick <bradfitz@golang.org>