Issue 7942045: code review 7942045: cmd/gc: more race instrumentation.

Issue 7942045: code review 7942045: cmd/gc: more race instrumentation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by remyoudompheng

Modified:
12 years ago

Reviewers:
dvyukov

CC:
golang-dev

Visibility:
Public.

Description

cmd/gc: more race instrumentation. Handle interface comparison correctly, add a few more tests, mark more nodes as impossible.

Patch Set 2 : diff -r d6a4fe5af6aa https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r d6a4fe5af6aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 924fbbd725d4 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -10 lines)			Patch
	M	src/cmd/gc/racewalk.c	View	1	4 chunks	+14 lines, -10 lines	0 comments	Download
	M	src/pkg/runtime/race/testdata/mop_test.go	View	1 2 3	4 chunks	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello dvyukov@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-26 00:25:49 UTC) #1

remyoudompheng

https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdata/mop_test.go File src/pkg/runtime/race/testdata/mop_test.go (right): https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdata/mop_test.go#newcode579 src/pkg/runtime/race/testdata/mop_test.go:579: func TestRaceIfaceCmp(t *testing.T) { This test fails without the ...

12 years ago (2013-03-26 00:26:01 UTC) #2

dvyukov

https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdata/mop_test.go File src/pkg/runtime/race/testdata/mop_test.go (right): https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdata/mop_test.go#newcode1261 src/pkg/runtime/race/testdata/mop_test.go:1261: var i Inter = InterImpl{} It is different from ...

12 years ago (2013-03-26 06:31:47 UTC) #4

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=08d20469cc20 *** cmd/gc: more race instrumentation. Handle interface comparison correctly, add a ...

12 years ago (2013-03-26 07:27:36 UTC) #5

dvyukov

12 years ago (2013-03-26 08:13:07 UTC) #6

Message was sent while issue was closed.

On 2013/03/26 07:27:36, remyoudompheng wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=08d20469cc20 ***
> 
> cmd/gc: more race instrumentation.
> 
> Handle interface comparison correctly,
> add a few more tests, mark more nodes as impossible.
> 
> R=dvyukov, golang-dev
> CC=golang-dev
> https://codereview.appspot.com/7942045
> 
>
https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdat...
> File src/pkg/runtime/race/testdata/mop_test.go (right):
> 
>
https://codereview.appspot.com/7942045/diff/2001/src/pkg/runtime/race/testdat...
> src/pkg/runtime/race/testdata/mop_test.go:1261: var i Inter = InterImpl{}
> On 2013/03/26 06:31:47, dvyukov wrote:
> > It is different from the previous test only by i declaration. Why is it
> > important?
> > I know the tests are not rich with comment, but please add one here
explaining
> > the difference.
> 
> Done.

// Method value with interface receiver.
Ah, I see

Expand All Messages | Collapse All Messages