Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 79320043: code review 79320043: go.image/vp8, go.image/webp: new packages, copied from (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by nigeltao
Modified:
10 years, 1 month ago
Reviewers:
r
CC:
r, aam, oleku, golang-codereviews
Visibility:
Public.

Description

go.image/vp8, go.image/webp: new packages, copied from code.google.com/p/vp8-go This is a straight copy, followed by import path updates.

Patch Set 1 #

Patch Set 2 : diff -r 14beb99f9689 https://code.google.com/p/go.image #

Patch Set 3 : diff -r 14beb99f9689 https://code.google.com/p/go.image #

Patch Set 4 : diff -r 21b73434ebf0 https://code.google.com/p/go.image #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2321 lines, -0 lines) Patch
A vp8/decode.go View 1 2 3 1 chunk +356 lines, -0 lines 0 comments Download
A vp8/idct.go View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download
A vp8/partition.go View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download
A vp8/pred.go View 1 2 3 1 chunk +201 lines, -0 lines 0 comments Download
A vp8/predfunc.go View 1 2 3 1 chunk +553 lines, -0 lines 0 comments Download
A vp8/quant.go View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
A vp8/reconstruct.go View 1 2 3 1 chunk +435 lines, -0 lines 0 comments Download
A vp8/token.go View 1 2 3 1 chunk +381 lines, -0 lines 0 comments Download
A webp/decode.go View 1 2 3 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 9
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image
10 years, 1 month ago (2014-03-24 05:48:55 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
10 years, 1 month ago (2014-03-24 05:51:49 UTC) #2
aam
this line should change at some point: On Sun, Mar 23, 2014 at 11:48 PM, ...
10 years, 1 month ago (2014-03-24 05:56:18 UTC) #3
aam
foiled by shift+enter, sorry. this is what i referenced: > goinstall code.google.com/p/vp8-go/webp it is from ...
10 years, 1 month ago (2014-03-24 05:58:09 UTC) #4
nigeltao
On Mon, Mar 24, 2014 at 4:58 PM, andrey mirtchovski <mirtchovski@gmail.com> wrote: > foiled by ...
10 years, 1 month ago (2014-03-24 06:20:42 UTC) #5
oleku
Nice .. any plans for encoder ? On Monday, March 24, 2014 7:20:41 AM UTC+1, ...
10 years, 1 month ago (2014-03-24 07:34:25 UTC) #6
r
LGTM but should you change the copyright string before checkin?
10 years, 1 month ago (2014-03-24 09:12:38 UTC) #7
nigeltao
On Mon, Mar 24, 2014 at 6:34 PM, Oleku Konko <oleku.konko@gmail.com> wrote: > Nice .. ...
10 years, 1 month ago (2014-03-25 02:29:59 UTC) #8
nigeltao
10 years, 1 month ago (2014-03-25 02:30:08 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=dc5d8934d75b&repo=image ***

go.image/vp8, go.image/webp: new packages, copied from
code.google.com/p/vp8-go

This is a straight copy, followed by import path updates.

LGTM=r
R=r, mirtchovski, oleku.konko
CC=golang-codereviews
https://codereview.appspot.com/79320043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b