code review 79210044: encoding/xml: Makes XML Marshaler take into account XML...

encoding/xml: Makes XML Marshaler take into account XMLName field from anonymous field

Fixes issue 7614.

[vizor, 2014-03-24 21:55:02]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[vizor, 2014-03-26 11:00:52]

Please take a look.

[vizor, 2014-03-27 16:03:46]

Please take a look.

[vizor, 2014-03-28 21:14:38]

Please take a look.

[rsc, 2014-03-28 21:20:17]

Hi. I see the CL, but I am heads down trying to get the compiler in better
shape. I will look at this CL next week.

Thanks very much.
Russ

[vizor, 2014-04-07 17:56:15]

Hi Russ,

Hope compiller is in a good shape now and you have a few minutes to review this
small patch :).

On 2014/03/28 21:20:17, rsc wrote:
> Hi. I see the CL, but I am heads down trying to get the compiler in better
> shape. I will look at this CL next week.
> 
> Thanks very much.
> Russ

[rsc, 2014-04-08 14:35:18]

LGTM

Thanks for your patience.

[rsc, 2014-04-08 14:36:31]

It looks you have not completed a CLA, at least not as alex.vizor@gmail.com; see
golang.org/doc/contribute.html#copyright

Thanks.

[vizor, 2014-04-08 14:40:51]

Oops, you are right, just completed it.

Regards,
Alexander

[rsc, 2014-04-08 15:12:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=337f8859f5be ***

encoding/xml: Makes XML Marshaler take into account XMLName field from anonymous
field

Fixes issue 7614.

LGTM=rsc
R=golang-codereviews, r, rsc, dan.kortschak, applezinc
CC=golang-codereviews
https://codereview.appspot.com/79210044

Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-04-08 15:44:03]

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/3cceeb16258ea47c77752ccfe03df9f4a5291697