Issue 7884043: code review 7884043: net: make use of reflect.DeepEqual in IP manipulation tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7884043: code review 7884043: net: make use of reflect.DeepEqual in IP manipulation tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by mikio

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net: make use of reflect.DeepEqual in IP manipulation tests Also applies camel style to test case holders.

Patch Set 1 : diff -r 786e094255c9 https://code.google.com/p/go #

Patch Set 2 : diff -r b4128b295144 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -58 lines)			Patch
	M	src/pkg/net/ip_test.go	View		16 chunks	+47 lines, -58 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-03-19 12:47:43 UTC) #1

mikio

12 years ago (2013-03-19 16:07:25 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4bcce3eefea7 ***

net: make use of reflect.DeepEqual in IP manipulation tests

Also applies camel style to test case holders.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7884043

Expand All Messages | Collapse All Messages