code review 7876043: runtime: fix tv_sec 32-bit overflows in sleep routines.

runtime: fix tv_sec 32-bit overflows in sleep routines.

Fixes issue 5063.

[remyoudompheng, 2013-03-16 22:20:28]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-03-16 22:49:01]

LGTM. is there a way to test this?

[remyoudompheng, 2013-03-17 09:21:37]

On 2013/03/16 22:49:01, minux wrote:
> LGTM. is there a way to test this?

I think a test would need to call semasleep/futexsleep (depending on OS)
directly to test the bug.
The following test fails before the patch and works after:

// +build linux freebsd

package runtime_test

import (
      . "runtime"
      "testing"
      "time"
)

func TestFutexsleep(t *testing.T) {
      ch := make(chan bool, 1)
      var dummy uint32
      start := time.Now()
      go func() {
            Entersyscall()
            Futexsleep(&dummy, 0, (1<<31+100) * 1e9)
            Exitsyscall()
            ch <- true
      }()
      select {
      case <-ch:
            t.Errorf("futexsleep finished early after %s!", time.Since(start))
      case <-time.After(time.Second):
            Futexwakeup(&dummy, 1)
      }
}

[remyoudompheng, 2013-03-17 09:38:00]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[minux1, 2013-03-18 12:34:20]

LGTM.

[rsc, 2013-03-18 13:38:15]

LGTM

[remyoudompheng, 2013-03-18 19:11:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=5c43f676b8ec ***

runtime: fix tv_sec 32-bit overflows in sleep routines.

Fixes issue 5063.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/7876043