Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4887)

Issue 78640043: code review 78640043: go.net/netutil: fix unintentional test deadlock on reso... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by mikio
Modified:
11 years ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

go.net/netutil: fix unintentional test deadlock on resource starvation It's been observed when the node under test has a tiny resource configutation or package http has changed the behavior of its own active connection pool. For example, http://build.golang.org/log/8912bc0944628cf1b4fe4063a77d36d19f9dd6a3

Patch Set 1 : diff -r 89dbba2db2d4 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 89dbba2db2d4 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M netutil/listen_test.go View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
11 years ago (2014-03-21 03:02:30 UTC) #1
adg
LGTM Please fix the change description (typo "behaviro")
11 years ago (2014-03-21 03:11:23 UTC) #2
mikio
11 years ago (2014-03-21 03:25:12 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=c17ad62118ea&repo=net ***

go.net/netutil: fix unintentional test deadlock on resource starvation

It's been observed when the node under test has a tiny resource
configutation or package http has changed the behavior of its own
active connection pool.

For example,
http://build.golang.org/log/8912bc0944628cf1b4fe4063a77d36d19f9dd6a3

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/78640043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b