code review 7860047: crypto/cipher: Added BlockMode for ECB Encryption and D...

crypto/cipher: Added BlockMode for ECB Encryption and Decryption.

[fasmat, 2013-03-24 11:58:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-03-25 00:23:54]

Sorry, but we're not adding new API again until after Go 1.1 is released.
Please ping this thread then.

golang.org/s/go11freeze

[gobot, 2013-04-18 02:52:49]

R=agl (assigned by dsymonds)

[fasmat, 2013-06-03 22:54:20]

Hello agl@chromium.org (cc: gobot@golang.org, golang-dev@googlegroups.com,
rsc@golang.org),

Please take another look.

[agl1, 2013-06-03 22:56:19]

ECB is deliberately not included because it's so vulnerable and easy to
implement yourself if need be. Is there an especially good use case for this?

[fasmat, 2013-06-03 23:04:32]

On 2013/06/03 22:56:19, agl1 wrote:
> ECB is deliberately not included because it's so vulnerable and easy to
> implement yourself if need be. Is there an especially good use case for this?

1. It is the only missing cipher method in the go libs.
2. It is the only cipher method that can be used to if partial decryption of a
file is required.
3. Security is only an issue if the decrypted file contains patterns that can be
used to identify and break the code.

[rsc, 2013-06-04 01:05:21]

I don't think we can be any clearer:
Thank you for the effort, but sorry, this code is not going in.

[agl, 2013-06-04 16:46:23]

On Mon, Jun 3, 2013 at 7:04 PM,  <fasching.matthias@gmail.com> wrote:
> 1. It is the only missing cipher method in the go libs.

That's certainly not the case. There are many cipher modes that we
don't implement: OFB, GCM, XEX, ...

> 2. It is the only cipher method that can be used to if partial
> decryption of a file is required.

Nope - CTR mode supports random access for one and some modes are
specifically designed for random writes (i.e. XTS).

> 3. Security is only an issue if the decrypted file contains patterns
> that can be used to identify and break the code.

While that's true, nearly all data that is encrypted contains patterns!


Cheers

AGL

[rsc, 2013-12-18 20:13:24]

R=close