code review 7814046: net/http: deflake BenchmarkServerFakeConnNoKeepAlive.

net/http: deflake BenchmarkServerFakeConnNoKeepAlive.

Fixes issue 5121.

[remyoudompheng, 2013-03-25 01:01:57]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-03-25 01:11:35]

LGTM
 On Mar 24, 2013 6:02 PM, <remyoudompheng@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: deflake BenchmarkServerFakeConnNoKeepA**live.
>
> Fixes issue 5121.
>
> Please review this at
https://codereview.appspot.**com/7814046/<https://codereview.appspot.com/7814...
>
> Affected files:
>   M src/pkg/net/http/serve_test.go
>
>
> Index: src/pkg/net/http/serve_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/serve_test.**go
> +++ b/src/pkg/net/http/serve_test.**go
> @@ -1635,7 +1635,9 @@
>         res := []byte("Hello world!\n")
>
>         conn := &testConn{
> -               closec: make(chan bool),
> +               // testConn.Close will not push into the channel
> +               // if it's full.
> +               closec: make(chan bool, 1),
>         }
>         handler := HandlerFunc(func(rw ResponseWriter, r *Request) {
>                 rw.Header().Set("Content-Type"**, "text/html;
> charset=utf-8")
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[remyoudompheng, 2013-03-25 07:17:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=010e981623de ***

net/http: deflake BenchmarkServerFakeConnNoKeepAlive.

Fixes issue 5121.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7814046