Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(987)

Issue 7812050: code review 7812050: doc: add summary of net/http additions to Go 1.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by bradfitz
Modified:
12 years ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

doc: add summary of net/http additions to Go 1.1

Patch Set 1 #

Patch Set 2 : diff -r b3cfb8be2faf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b3cfb8be2faf https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 4 : diff -r b3cfb8be2faf https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2bc153c7d415 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M doc/go1.1.html View 1 2 3 4 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-03-25 21:24:49 UTC) #1
r
https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html#newcode725 doc/go1.1.html:725: <a href="/pkg/net/http/#ParseTime"><code>ParseTime</code></a> parses time string in one of "parses ...
12 years ago (2013-03-25 21:31:21 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years ago (2013-03-25 22:10:40 UTC) #3
r
LGTM but i'd s/Additionally/Finally/ since it's the last one in the block.
12 years ago (2013-03-25 22:16:30 UTC) #4
bradfitz
12 years ago (2013-03-25 22:17:46 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=abf073eb4f74 ***

doc: add summary of net/http additions to Go 1.1

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7812050

https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html
File doc/go1.1.html (right):

https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html#newcode725
doc/go1.1.html:725: <a
href="/pkg/net/http/#ParseTime"><code>ParseTime</code></a> parses time string in
one of
On 2013/03/25 21:31:21, r wrote:
> "parses time string": missing article. 

whoops

> Also, what time string? Why not
> time.Parse?

Clarified.

https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html#newcode727
doc/go1.1.html:727: The <a
href="/pkg/net/http/#Request.PostFormValue">PostFormValue</a> method on
On 2013/03/25 21:31:21, r wrote:
> s/on/of/

Done.

https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html#newcode731
doc/go1.1.html:731: for server handler to discover when a client has
disconnected.
On 2013/03/25 21:31:21, r wrote:
> for A server handler

Done.

https://codereview.appspot.com/7812050/diff/3001/doc/go1.1.html#newcode733
doc/go1.1.html:733: <a
href="/pkg/net/http/#ServeMux.Handler"><code>Handler</code></a> method to get a
path's
On 2013/03/25 21:31:21, r wrote:
> s/get/access/ ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b