code review 781041: bytes, strings: IndexOfAny

bytes, strings: IndexOfAny
+ first use in go/doc

[gri, 2010-03-26 18:06:11]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-03-26 18:12:17]

not sure about the Of.
the existing function is Index, not IndexOf.
but i don't have a better suggestion.
strpbrk isn't better ;-)

regardless, same func should probably
be in bytes.

russ

[r2, 2010-03-26 18:23:00]

On Mar 26, 2010, at 11:12 AM, Russ Cox wrote:

> not sure about the Of.
> the existing function is Index, not IndexOf.
> but i don't have a better suggestion.
> strpbrk isn't better ;-)
>
> regardless, same func should probably
> be in bytes.

yeah, drop the Of and put it in bytes.

-rob

[gri, 2010-03-26 18:32:21]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-03-26 19:47:28]

LGTM but wait for rsc

http://codereview.appspot.com/781041/diff/17001/18004
File src/pkg/strings/strings.go (right):

http://codereview.appspot.com/781041/diff/17001/18004#newcode109
src/pkg/strings/strings.go:109: // IndexAny returns the index of the first
instance of any character
s/character/Unicode code point/ in the comments for both functions

http://codereview.appspot.com/781041/diff/17001/18004#newcode114
src/pkg/strings/strings.go:114: for _, m := range chars {
i wonder if this is the best implementatino but it's fine for now

[rsc1, 2010-03-26 20:02:54]

LGTM

[gri, 2010-03-26 20:05:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=45f7ce20ba02 ***

bytes, strings: IndexOfAny
+ first use in go/doc

R=r
CC=golang-dev
http://codereview.appspot.com/781041