code review 7777047: encoding/xml: predefine xml name space prefix

encoding/xml: predefine xml name space prefix

Also change prefix generation to use more human-friendly prefixes.

Fixes issue 5040.

[rsc, 2013-03-13 18:18:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2013-03-13 18:22:52]

LGTM

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal.go
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal...
src/pkg/encoding/xml/marshal.go:144: if url ==
"http://www.w3.org/XML/1998/namespace" {
should this and the other be exported constants?

[bradfitz, 2013-03-13 18:25:44]

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal.go
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal...
src/pkg/encoding/xml/marshal.go:163: if p.attrNS[prefix] != "" {
|| prefix == "xml" ?

[rsc, 2013-03-13 18:34:07]

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal.go
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal...
src/pkg/encoding/xml/marshal.go:144: if url ==
"http://www.w3.org/XML/1998/namespace" {
On 2013/03/13 18:22:52, r wrote:
> should this and the other be exported constants?

I made it an unexported constant. The only time clients care is when
constructing struct field tags, and there a named constant is not helpful.

https://codereview.appspot.com/7777047/diff/2001/src/pkg/encoding/xml/marshal...
src/pkg/encoding/xml/marshal.go:163: if p.attrNS[prefix] != "" {
On 2013/03/13 18:25:45, bradfitz wrote:
> || prefix == "xml" ?

Done, thanks. In fact any prefix beginning with "xml" is forbidden.

[rsc, 2013-03-13 18:36:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=278c4b3d927c ***

encoding/xml: predefine xml name space prefix

Also change prefix generation to use more human-friendly prefixes.

Fixes issue 5040.

R=golang-dev, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/7777047