Issue 7743043: code review 7743043: encoding/xml: allow embedded non-structs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7743043: code review 7743043: encoding/xml: allow embedded non-structs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

encoding/xml: allow embedded non-structs The old code just assumed that the only thing you can embed is a struct. Not true. Fixes issue 3803.

Patch Set 1 #

Patch Set 2 : diff -r 3a91fdb19566 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a91fdb19566 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ae5a4de1885a https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -12 lines)			Patch
	M	src/pkg/encoding/xml/marshal_test.go	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/xml/typeinfo.go	View	1	1 chunk	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2013-03-12 03:31:59 UTC) #1

rsc

11 years, 1 month ago (2013-03-12 03:58:26 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c15b9434ebaf ***

encoding/xml: allow embedded non-structs

The old code just assumed that the only thing
you can embed is a struct. Not true.

Fixes issue 3803.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7743043

Expand All Messages | Collapse All Messages