Issue 77420044: code review 77420044: bytes: fix panic in Map

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77420044: code review 77420044: bytes: fix panic in Map (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by ruiu

Modified:
10 years, 1 month ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

bytes: fix panic in Map utf8.RuneLen returns -1 for an invalid rune. In that case we need to extend the internal buffer at least by 3 for \uFFFD. Fixes issue 7577.

Patch Set 1 #

Patch Set 2 : diff -r 50cee9f42671 https://code.google.com/p/go #

Patch Set 3 : diff -r 50cee9f42671 https://code.google.com/p/go #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/pkg/bytes/bytes.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/pkg/bytes/bytes_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ruiu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-03-19 01:57:04 UTC) #1

iant

I think the "Fixes issue" needs to start on a line by itself so that ...

10 years, 1 month ago (2014-03-19 03:52:38 UTC) #3

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=d57a0d25513d *** bytes: fix panic in Map utf8.RuneLen returns -1 for an ...

10 years, 1 month ago (2014-03-19 03:53:08 UTC) #4

gobot

10 years, 1 month ago (2014-03-19 04:54:38 UTC) #5

This CL appears to have broken the windows-386-ec2 builder.
See http://build.golang.org/log/749e72ffb1337268bb27f3a44c62607ddd493f1a

Expand All Messages | Collapse All Messages