Issue 7741050: code review 7741050: pkg/runtime: ignore runtime.memlimit when allocating heap

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7741050: code review 7741050: pkg/runtime: ignore runtime.memlimit when allocating heap (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by iant

Modified:
11 years, 1 month ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

pkg/runtime: ignore runtime.memlimit when allocating heap For Go 1.1, stop checking the rlimit, because it broke now that mheap is allocated using SysAlloc. See issue 5049.

Patch Set 1 #

Patch Set 2 : diff -r 1296263f017c https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/pkg/runtime/malloc.goc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2013-03-26 20:41:03 UTC) #1

iant

11 years, 1 month ago (2013-03-26 21:01:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7e0a61d4b081 ***

pkg/runtime: ignore runtime.memlimit when allocating heap

For Go 1.1, stop checking the rlimit, because it broke now
that mheap is allocated using SysAlloc.  See issue 5049.

R=r
CC=golang-dev
https://codereview.appspot.com/7741050

Expand All Messages | Collapse All Messages