code review 7737043: net: Plan 9: add lookupProtocol

net: Plan 9: add lookupProtocol

Needed by TestResolveIPAddr. This makes us pass tests
again.

[akumar, 2013-03-11 23:13:51]

Hello rsc@golang.org, rminnich@gmail.com, ality@pbrane.org, bradfitz@golang.org
(cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rminnich, 2013-03-12 20:38:57]

https://codereview.appspot.com/7737043/diff/5001/src/pkg/net/lookup_plan9.go
File src/pkg/net/lookup_plan9.go (right):

https://codereview.appspot.com/7737043/diff/5001/src/pkg/net/lookup_plan9.go#...
src/pkg/net/lookup_plan9.go:75: lines, err := query("/net/cs",
"!protocol="+name+" ipv4proto=*", 128)
I was wondering why this is hardwired to ipv4. Is there a reason?

[akumar, 2013-03-12 20:49:22]

PTAL.

https://codereview.appspot.com/7737043/diff/5001/src/pkg/net/lookup_plan9.go
File src/pkg/net/lookup_plan9.go (right):

https://codereview.appspot.com/7737043/diff/5001/src/pkg/net/lookup_plan9.go#...
src/pkg/net/lookup_plan9.go:75: lines, err := query("/net/cs",
"!protocol="+name+" ipv4proto=*", 128)
On 2013/03/12 20:38:57, rminnich wrote:
> I was wondering why this is hardwired to ipv4. Is there a reason?

The Plan 9 ndb/common file only specifies protocol
numbers with that corresponding string, but I can
accommodate for future changes here.

Done.

[rminnich, 2013-03-12 20:51:26]

LGTM

[rminnich, 2013-03-12 22:07:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=95031c549c51 ***

net: Plan 9: add lookupProtocol

Needed by TestResolveIPAddr. This makes us pass tests
again.

R=rsc, rminnich, ality, bradfitz
CC=golang-dev
https://codereview.appspot.com/7737043

Committer: Ron Minnich <rminnich@gmail.com>