Issue 7725048: code review 7725048: doc: add DialOpt and friends to go1.1.html

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7725048: code review 7725048: doc: add DialOpt and friends to go1.1.html (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

doc: add DialOpt and friends to go1.1.html

Patch Set 2 : diff -r f78c5036b7f6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f78c5036b7f6 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r f78c5036b7f6 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 2be8c885acc8 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	doc/go1.1.html	View	1 2 3 4	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-25 17:07:15 UTC) #1

https://codereview.appspot.com/7725048/diff/5001/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/7725048/diff/5001/doc/go1.1.html#newcode713 doc/go1.1.html:713: options. Each option is represented by a new s/to ...

12 years ago (2013-03-25 17:18:49 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years ago (2013-03-25 17:25:34 UTC) #3

LGTM https://codereview.appspot.com/7725048/diff/10001/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/7725048/diff/10001/doc/go1.1.html#newcode716 doc/go1.1.html:716: interface. The new functions i'm trying to use ...

12 years ago (2013-03-25 17:27:02 UTC) #4

bradfitz

12 years ago (2013-03-25 17:31:27 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=2334cbe0190b ***

doc: add DialOpt and friends to go1.1.html

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7725048

Expand All Messages | Collapse All Messages