Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(670)

Issue 77140044: code review 77140044: fmt: document GoStringer and explain application of for... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by r
Modified:
10 years, 2 months ago
Reviewers:
josharian
CC:
golang-codereviews, josharian
Visibility:
Public.

Description

fmt: document GoStringer and explain application of formats to compound objects %q quotes each element of a string slice; this was never explained in the docs. Fixes issue 7015.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 2162d6893121 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/pkg/fmt/doc.go View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 2 months ago (2014-03-17 23:56:55 UTC) #1
josharian
LGTM with nits https://codereview.appspot.com/77140044/diff/1/src/pkg/fmt/doc.go File src/pkg/fmt/doc.go (right): https://codereview.appspot.com/77140044/diff/1/src/pkg/fmt/doc.go#newcode120 src/pkg/fmt/doc.go:120: invoked if the '%#v' verb (only) ...
10 years, 2 months ago (2014-03-18 00:09:38 UTC) #2
r
10 years, 2 months ago (2014-03-18 00:24:37 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=740f2c9af41e ***

fmt: document GoStringer and explain application of formats to compound objects
%q quotes each element of a string slice; this was never explained in the docs.
Fixes issue 7015.

LGTM=josharian
R=golang-codereviews, josharian
CC=golang-codereviews
https://codereview.appspot.com/77140044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b