Issue 7689044: code review 7689044: go.talk: Content fixes for GAE deployment. appcf...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7689044: code review 7689044: go.talk: Content fixes for GAE deployment. appcf...

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by wathiede

Modified:
10 years, 9 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

go.talk: Content fixes for GAE deployment. appcfg.py wants to compile everything, and select.go has some errors in it preventing deploment. The part being cleaned-up here isn't present in the content of the presentation: http://talks.golang.org/2012/concurrency.slide#32

Patch Set 1 #

Patch Set 2 : diff -r fea06511a4a2 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r fea06511a4a2 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 7597f5c52a13 https://code.google.com/p/go.talks #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	2012/concurrency/support/select.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

wathiede

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 1 month ago (2013-03-11 17:13:50 UTC) #1

wathiede

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 11 months ago (2013-05-14 17:03:54 UTC) #2

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=997801fbaec9&repo=talks *** go.talk: Content fixes for GAE deployment. appcfg.py wants to compile ...

10 years, 10 months ago (2013-06-17 21:03:49 UTC) #4

R=close

Expand All Messages | Collapse All Messages