Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2944)

Issue 7686043: sync: add Counter and Cache

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dvyukov
Modified:
10 years, 10 months ago
Reviewers:
bradfitz, james4k
Visibility:
Public.

Description

sync: add Counter and Cache

Patch Set 1 #

Patch Set 2 : diff -r 7778f3df0d19 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7778f3df0d19 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7778f3df0d19 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M src/pkg/runtime/proc.c View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/sync/cache.go View 1 2 1 chunk +46 lines, -0 lines 4 comments Download
A src/pkg/sync/cache_test.go View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A src/pkg/sync/counter.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A src/pkg/sync/counter_test.go View 1 1 chunk +83 lines, -0 lines 0 comments Download
A src/pkg/sync/proclocal.go View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Nice. https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go File src/pkg/sync/cache.go (right): https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go#newcode30 src/pkg/sync/cache.go:30: // Returns false if the case cache is ...
11 years, 1 month ago (2013-03-11 00:41:23 UTC) #1
dvyukov
On 2013/03/11 00:41:23, bradfitz wrote: > Nice. > > https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go > File src/pkg/sync/cache.go (right): > ...
11 years, 1 month ago (2013-03-11 05:58:33 UTC) #2
james4k
https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go File src/pkg/sync/cache.go (right): https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go#newcode9 src/pkg/sync/cache.go:9: Mutex Is this mutex needed?
10 years, 10 months ago (2013-06-04 17:36:30 UTC) #3
dvyukov
10 years, 10 months ago (2013-06-04 17:46:41 UTC) #4
https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go
File src/pkg/sync/cache.go (right):

https://codereview.appspot.com/7686043/diff/6001/src/pkg/sync/cache.go#newcode9
src/pkg/sync/cache.go:9: Mutex
On 2013/06/04 17:36:30, james4k wrote:
> Is this mutex needed?

It would be needed for Drain/SetCapacity methods.
This is a draft CL, little sense in looking at it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b