Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1508)

Issue 76770043: code review 76770043: go.talks/present: add flag to use Native Client for pla... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by kortschak
Modified:
9 years, 8 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

go.talks/present: add flag to use Native Client for playground code execution Depends on CL77240043 or equivalent.

Patch Set 1 #

Patch Set 2 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 4 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 5 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 7 : diff -r 1205b8295b19 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M present/local.go View 1 2 3 4 5 6 5 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 13
kortschak
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years ago (2014-03-17 05:57:05 UTC) #1
adg
https://codereview.appspot.com/76770043/diff/40001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/40001/present/local.go#newcode52 present/local.go:52: if runtime.GOARCH == "amd64" { ah, you need to ...
10 years ago (2014-03-17 06:25:29 UTC) #2
kortschak
PTAL https://codereview.appspot.com/76770043/diff/40001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/40001/present/local.go#newcode52 present/local.go:52: if runtime.GOARCH == "amd64" { On 2014/03/17 06:25:29, ...
10 years ago (2014-03-17 22:41:16 UTC) #3
adg
https://codereview.appspot.com/76770043/diff/60001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/60001/present/local.go#newcode53 present/local.go:53: return append(os.Environ(), "GOOS=nacl", "GOARCH=amd64p32") Ah, sorry, I forgot that ...
10 years ago (2014-03-18 21:40:04 UTC) #4
kortschak
PTAL https://codereview.appspot.com/76770043/diff/60001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/60001/present/local.go#newcode53 present/local.go:53: return append(os.Environ(), "GOOS=nacl", "GOARCH=amd64p32") On 2014/03/18 21:40:05, adg ...
10 years ago (2014-03-18 23:29:59 UTC) #5
kortschak
One additional question that's worth asking here. Can we trust NaCl enough that the warning ...
10 years ago (2014-03-19 00:24:27 UTC) #6
adg
I was thinking the same thing. I think so, yes. Please add that change to ...
10 years ago (2014-03-19 00:28:49 UTC) #7
kortschak
codereview has just had a fit - I was unable to upload with a claim ...
10 years ago (2014-03-19 00:52:16 UTC) #8
adg
Just delete this one create a new CL if you get frustrated. On 19 March ...
10 years ago (2014-03-19 00:56:32 UTC) #9
kortschak
It's worked. Thanks. On 2014/03/19 00:56:32, adg wrote: > Just delete this one create a ...
10 years ago (2014-03-19 00:58:18 UTC) #10
adg
LGTM https://codereview.appspot.com/76770043/diff/100001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/100001/present/local.go#newcode27 present/local.go:27: drop the space https://codereview.appspot.com/76770043/diff/100001/present/local.go#newcode77 present/local.go:77: func environ(vars ...string) ...
10 years ago (2014-03-19 22:51:29 UTC) #11
kortschak
Thanks for the feedback - always a pleasure. https://codereview.appspot.com/76770043/diff/100001/present/local.go File present/local.go (right): https://codereview.appspot.com/76770043/diff/100001/present/local.go#newcode27 present/local.go:27: On ...
10 years ago (2014-03-20 02:27:24 UTC) #12
adg
10 years ago (2014-03-20 03:52:06 UTC) #13
*** Submitted as
https://code.google.com/p/go/source/detail?r=13236f5b7fb6&repo=talks ***

go.talks/present: add flag to use Native Client for playground code execution

Depends on CL77240043 or equivalent.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/76770043

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b