Issue 7676044: code review 7676044: go.talks: fix build by removing dependancy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7676044: code review 7676044: go.talks: fix build by removing dependancy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by adg

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go.talks: fix build by removing dependency

Patch Set 2 : diff -r cfb39ab17d34 https://code.google.com/p/go.talks #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	2012/tutorial/main.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 1 month ago (2013-03-11 00:45:02 UTC) #1

LGTM but why does this remove a dependency? also fix the spelling mistake in your ...

11 years, 1 month ago (2013-03-11 00:47:32 UTC) #2

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=fea06511a4a2&repo=talks *** go.talks: fix build by removing dependency R=golang-dev, r CC=golang-dev https://codereview.appspot.com/7676044

11 years, 1 month ago (2013-03-11 00:53:16 UTC) #3

adg

11 years, 1 month ago (2013-03-11 00:53:18 UTC) #4

main.go imports github.com/nf/reddit.


On 11 March 2013 11:47, <r@golang.org> wrote:

> LGTM
>
> but why does this remove a dependency?
> also fix the spelling mistake in your CL.
>
>
>
https://codereview.appspot.**com/7676044/<https://codereview.appspot.com/7676...
>

Expand All Messages | Collapse All Messages