Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3183)

Issue 7663051: code review 7663051: runtime: optionally check all allocations in hashmap.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by atom
Modified:
12 years ago
Reviewers:
CC:
golang-dev, khr, rsc
Visibility:
Public.

Description

runtime: optionally check all allocations in hashmap.c Adds the new debugging constant 'checkgc'. If its value is non-zero all calls to mallocgc() from hashmap.c will start a garbage collection. Fixes issue 5074.

Patch Set 1 #

Patch Set 2 : diff -r 2334cbe0190b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/pkg/runtime/hashmap.c View 7 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5
atom
Hello golang-dev@googlegroups.com (cc: rsc, khr), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-03-23 08:51:19 UTC) #1
khr
On 2013/03/23 08:51:19, atom wrote: > Hello mailto:golang-dev@googlegroups.com (cc: rsc, khr), > > I'd like ...
12 years ago (2013-03-23 15:58:16 UTC) #2
rsc
(You don't need to wait for me, if you are.)
12 years ago (2013-03-25 20:26:29 UTC) #3
atom
On 2013/03/25 20:26:29, rsc wrote: > (You don't need to wait for me, if you ...
12 years ago (2013-03-25 20:35:32 UTC) #4
atom
12 years ago (2013-03-25 20:35:55 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=f0a9210fdd8c ***

runtime: optionally check all allocations in hashmap.c

Adds the new debugging constant 'checkgc'. If its value is non-zero
all calls to mallocgc() from hashmap.c will start a garbage collection.

Fixes issue 5074.

R=golang-dev, khr
CC=golang-dev, rsc
https://codereview.appspot.com/7663051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b