Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 7656044: code review 7656044: go/types: add to the go.exp repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by r
Modified:
11 years ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

go/types: add to the go.exp repo See also https://codereview.appspot.com/7625048 Fixes issue 4870.

Patch Set 1 #

Patch Set 2 : diff -r 93e7901891c5 https://code.google.com/p/go.exp #

Patch Set 3 : diff -r aa678ea78eb7 https://code.google.com/p/go.exp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11214 lines, -18 lines) Patch
A go/types/api.go View 1 1 chunk +105 lines, -0 lines 0 comments Download
A go/types/builtins.go View 1 1 chunk +451 lines, -0 lines 0 comments Download
A go/types/check.go View 1 1 chunk +512 lines, -0 lines 0 comments Download
A go/types/check_test.go View 1 1 chunk +244 lines, -0 lines 0 comments Download
A go/types/const.go View 1 1 chunk +724 lines, -0 lines 0 comments Download
A go/types/conversions.go View 1 1 chunk +155 lines, -0 lines 0 comments Download
A go/types/errors.go View 1 1 chunk +335 lines, -0 lines 0 comments Download
A go/types/exportdata.go View 1 1 chunk +111 lines, -0 lines 0 comments Download
A go/types/expr.go View 1 1 chunk +1637 lines, -0 lines 0 comments Download
A go/types/gcimporter.go View 1 1 chunk +950 lines, -0 lines 0 comments Download
A go/types/gcimporter_test.go View 1 1 chunk +180 lines, -0 lines 0 comments Download
A go/types/objects.go View 1 1 chunk +187 lines, -0 lines 0 comments Download
A go/types/operand.go View 1 1 chunk +411 lines, -0 lines 0 comments Download
A go/types/predicates.go View 1 1 chunk +303 lines, -0 lines 0 comments Download
A go/types/resolve.go View 1 1 chunk +197 lines, -0 lines 0 comments Download
A go/types/resolver_test.go View 1 1 chunk +167 lines, -0 lines 0 comments Download
A go/types/return.go View 1 1 chunk +189 lines, -0 lines 0 comments Download
A go/types/scope.go View 1 1 chunk +78 lines, -0 lines 0 comments Download
A go/types/sizes.go View 1 1 chunk +162 lines, -0 lines 0 comments Download
A go/types/stdlib_test.go View 1 1 chunk +133 lines, -0 lines 0 comments Download
A go/types/stmt.go View 1 1 chunk +722 lines, -0 lines 0 comments Download
A go/types/testdata/builtins.src View 1 1 chunk +426 lines, -0 lines 0 comments Download
A go/types/testdata/const0.src View 1 1 chunk +215 lines, -0 lines 0 comments Download
A go/types/testdata/conversions.src View 1 1 chunk +36 lines, -0 lines 0 comments Download
A go/types/testdata/decls0.src View 1 1 chunk +187 lines, -0 lines 0 comments Download
A go/types/testdata/decls1.src View 1 1 chunk +132 lines, -0 lines 0 comments Download
A go/types/testdata/decls2a.src View 1 1 chunk +66 lines, -0 lines 0 comments Download
A go/types/testdata/decls2b.src View 1 1 chunk +28 lines, -0 lines 0 comments Download
A go/types/testdata/decls3.src View 1 1 chunk +253 lines, -0 lines 0 comments Download
A go/types/testdata/exports.go View 1 1 chunk +89 lines, -0 lines 0 comments Download
A go/types/testdata/expr0.src View 1 1 chunk +161 lines, -0 lines 0 comments Download
A go/types/testdata/expr1.src View 1 1 chunk +7 lines, -0 lines 0 comments Download
A go/types/testdata/expr2.src View 1 1 chunk +23 lines, -0 lines 0 comments Download
A go/types/testdata/expr3.src View 1 1 chunk +338 lines, -0 lines 0 comments Download
A go/types/testdata/shifts.src View 1 1 chunk +266 lines, -0 lines 0 comments Download
A go/types/testdata/stmt0.src View 1 1 chunk +288 lines, -0 lines 0 comments Download
A go/types/testdata/stmt1.src View 1 1 chunk +164 lines, -0 lines 0 comments Download
A go/types/types.go View 1 1 chunk +236 lines, -0 lines 0 comments Download
A go/types/types_test.go View 1 1 chunk +171 lines, -0 lines 0 comments Download
A go/types/universe.go View 1 1 chunk +146 lines, -0 lines 0 comments Download
M gotype/gotype.go View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gotype/gotype_test.go View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ssa/builder.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/emit.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/func.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/importer.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/interp/interp.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/interp/map.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/interp/ops.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/interp/reflect.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/interp/value.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/lift.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/literal.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/lvalue.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/print.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/promote.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/ssa.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M ssa/util.go View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.exp
11 years ago (2013-03-11 21:11:32 UTC) #1
gri
LGTM
11 years ago (2013-03-12 19:49:52 UTC) #2
r
11 years ago (2013-03-12 20:51:14 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=54d6221b1742&repo=exp ***

go/types: add  to the go.exp repo
See also https://codereview.appspot.com/7625048
Fixes issue 4870.

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/7656044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b