code review 76470043: net/http: make use of testing.Errorf instead of testing...

net/http: make use of testing.Errorf instead of testing.Fatalf in non-test function goroutines

See testing.FailNow for further information.
Also avoid nil pointer derefernce in TestTransportMaxPerHostIdleConns.

[mikio, 2014-03-16 02:53:59]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-03-16 11:02:42]

LGTM with minor comments.

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
File src/pkg/net/http/transport_test.go (right):

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:354: _, err = ioutil.ReadAll(resp.Body)
if _, err := ... { 
   t.Errorf(...)
   return
}

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:359: donech <- true
same

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:1814: return
same

[mikio, 2014-03-18 12:12:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=262af7c32d11 ***

net/http: make use of testing.Errorf instead of testing.Fatalf in non-test
function goroutines

See testing.FailNow for further information.
Also avoid nil pointer derefernce in TestTransportMaxPerHostIdleConns.

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/76470043

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
File src/pkg/net/http/transport_test.go (right):

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:354: _, err = ioutil.ReadAll(resp.Body)
On 2014/03/16 11:02:43, dfc wrote:
> if _, err := ... { 
>    t.Errorf(...)
>    return
> }

Done.

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:359: donech <- true
On 2014/03/16 11:02:43, dfc wrote:
> same

not really

https://codereview.appspot.com/76470043/diff/40001/src/pkg/net/http/transport...
src/pkg/net/http/transport_test.go:1814: return
On 2014/03/16 11:02:43, dfc wrote:
> same

not really

[gobot, 2014-03-18 12:27:42]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/8600d29fe35e6ad33e770a745284f52e048531a1