code review 7627048: net: use original raddr if getpeername fails

net: use original raddr if getpeername fails

This CL updates CL 7511043;
- adds new test cases for both UDPConn and UnixConn,
- makes sure unnamed UnixAddr handling,
- replaces t.Errorf with t.Fatalf in sockname related test cases.

Fixes issue 3721 (again).
Fixes issue 3838 (again).

[mikio, 2013-03-22 12:26:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2013-03-22 14:31:09]

LGTM

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/ipraw_test.go
File src/pkg/net/ipraw_test.go (right):

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/ipraw_test.go#ne...
src/pkg/net/ipraw_test.go:50: var ipConnLocalNameTests = []struct {
It's very disorienting to review code when big blocks move within the file.
Codereview is not showing me what's different, and people going through the hg
history later will not be able to see the differences either.

Please move this back to the end of the file so that diffs are clearer.

Thanks.

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/udp_test.go
File src/pkg/net/udp_test.go (right):

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/udp_test.go#newc...
src/pkg/net/udp_test.go:43: var udpConnLocalNameTests = []struct {
Same comment. Here I can tell that there are differences because it's longer,
but again please put the code back where it was so the diffs can be seen.

[mikio, 2013-03-23 00:01:22]

PTAL

Fixes tests on Linux,
Hm, autobind feature for AF_UNIX.

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/ipraw_test.go
File src/pkg/net/ipraw_test.go (right):

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/ipraw_test.go#ne...
src/pkg/net/ipraw_test.go:50: var ipConnLocalNameTests = []struct {
On 2013/03/22 14:31:09, rsc wrote:
> It's very disorienting to review code when big blocks move within the file.
> Codereview is not showing me what's different, and people going through the hg
> history later will not be able to see the differences either.
> 
> Please move this back to the end of the file so that diffs are clearer.
> 
> Thanks.

Done.

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/udp_test.go
File src/pkg/net/udp_test.go (right):

https://codereview.appspot.com/7627048/diff/5001/src/pkg/net/udp_test.go#newc...
src/pkg/net/udp_test.go:43: var udpConnLocalNameTests = []struct {
On 2013/03/22 14:31:09, rsc wrote:
> Same comment. Here I can tell that there are differences because it's longer,
> but again please put the code back where it was so the diffs can be seen.

Done.

[mikio, 2013-03-23 13:32:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=ec0937aebe0a ***

net: use original raddr if getpeername fails

This CL updates CL 7511043;
- adds new test cases for both UDPConn and UnixConn,
- makes sure unnamed UnixAddr handling,
- replaces t.Errorf with t.Fatalf in sockname related test cases.

Fixes issue 3721 (again).
Fixes issue 3838 (again).

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7627048