Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3300)

Issue 7625048: code review 7625048: go/types: delete from main repo; part of move to go.exp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by r
Modified:
11 years, 1 month ago
Reviewers:
minux1
CC:
golang-dev, gri, rsc
Visibility:
Public.

Description

go/types: delete from main repo; part of move to go.exp See also https://codereview.appspot.com/7656044

Patch Set 1 #

Patch Set 2 : diff -r 6db3ee1a6ff3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6db3ee1a6ff3 https://code.google.com/p/go #

Patch Set 4 : diff -r 55d0e841ab0b https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11193 lines) Patch
M src/cmd/vet/types.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/make.bash View 1 2 3 1 chunk +2 lines, -3 lines 1 comment Download
M src/make.bat View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
R src/pkg/go/types/api.go View 1 1 chunk +0 lines, -105 lines 0 comments Download
R src/pkg/go/types/builtins.go View 1 1 chunk +0 lines, -451 lines 0 comments Download
R src/pkg/go/types/check.go View 1 1 chunk +0 lines, -512 lines 0 comments Download
R src/pkg/go/types/check_test.go View 1 1 chunk +0 lines, -244 lines 0 comments Download
R src/pkg/go/types/const.go View 1 1 chunk +0 lines, -724 lines 0 comments Download
R src/pkg/go/types/conversions.go View 1 1 chunk +0 lines, -155 lines 0 comments Download
R src/pkg/go/types/errors.go View 1 1 chunk +0 lines, -335 lines 0 comments Download
R src/pkg/go/types/exportdata.go View 1 1 chunk +0 lines, -111 lines 0 comments Download
R src/pkg/go/types/expr.go View 1 1 chunk +0 lines, -1637 lines 0 comments Download
R src/pkg/go/types/gcimporter.go View 1 1 chunk +0 lines, -950 lines 0 comments Download
R src/pkg/go/types/gcimporter_test.go View 1 1 chunk +0 lines, -180 lines 0 comments Download
R src/pkg/go/types/objects.go View 1 1 chunk +0 lines, -187 lines 0 comments Download
R src/pkg/go/types/operand.go View 1 1 chunk +0 lines, -411 lines 0 comments Download
R src/pkg/go/types/predicates.go View 1 1 chunk +0 lines, -303 lines 0 comments Download
R src/pkg/go/types/resolve.go View 1 1 chunk +0 lines, -197 lines 0 comments Download
R src/pkg/go/types/resolver_test.go View 1 1 chunk +0 lines, -167 lines 0 comments Download
R src/pkg/go/types/return.go View 1 1 chunk +0 lines, -189 lines 0 comments Download
R src/pkg/go/types/scope.go View 1 1 chunk +0 lines, -78 lines 0 comments Download
R src/pkg/go/types/sizes.go View 1 1 chunk +0 lines, -162 lines 0 comments Download
R src/pkg/go/types/stdlib_test.go View 1 1 chunk +0 lines, -133 lines 0 comments Download
R src/pkg/go/types/stmt.go View 1 1 chunk +0 lines, -722 lines 0 comments Download
R src/pkg/go/types/testdata/builtins.src View 1 1 chunk +0 lines, -426 lines 0 comments Download
R src/pkg/go/types/testdata/const0.src View 1 1 chunk +0 lines, -215 lines 0 comments Download
R src/pkg/go/types/testdata/conversions.src View 1 1 chunk +0 lines, -36 lines 0 comments Download
R src/pkg/go/types/testdata/decls0.src View 1 1 chunk +0 lines, -187 lines 0 comments Download
R src/pkg/go/types/testdata/decls1.src View 1 1 chunk +0 lines, -132 lines 0 comments Download
R src/pkg/go/types/testdata/decls2a.src View 1 1 chunk +0 lines, -66 lines 0 comments Download
R src/pkg/go/types/testdata/decls2b.src View 1 1 chunk +0 lines, -28 lines 0 comments Download
R src/pkg/go/types/testdata/decls3.src View 1 1 chunk +0 lines, -253 lines 0 comments Download
R src/pkg/go/types/testdata/exports.go View 1 1 chunk +0 lines, -89 lines 0 comments Download
R src/pkg/go/types/testdata/expr0.src View 1 1 chunk +0 lines, -161 lines 0 comments Download
R src/pkg/go/types/testdata/expr1.src View 1 1 chunk +0 lines, -7 lines 0 comments Download
R src/pkg/go/types/testdata/expr2.src View 1 1 chunk +0 lines, -23 lines 0 comments Download
R src/pkg/go/types/testdata/expr3.src View 1 1 chunk +0 lines, -338 lines 0 comments Download
R src/pkg/go/types/testdata/shifts.src View 1 1 chunk +0 lines, -266 lines 0 comments Download
R src/pkg/go/types/testdata/stmt0.src View 1 1 chunk +0 lines, -288 lines 0 comments Download
R src/pkg/go/types/testdata/stmt1.src View 1 1 chunk +0 lines, -164 lines 0 comments Download
R src/pkg/go/types/types.go View 1 1 chunk +0 lines, -236 lines 0 comments Download
R src/pkg/go/types/types_test.go View 1 1 chunk +0 lines, -171 lines 0 comments Download
R src/pkg/go/types/universe.go View 1 1 chunk +0 lines, -146 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-03-11 21:11:27 UTC) #1
gri
LGTM
11 years, 1 month ago (2013-03-12 19:51:16 UTC) #2
rsc
Please update make.bash in this CL to drop the -tags gotypes. Otherwise all.bash will fail ...
11 years, 1 month ago (2013-03-12 19:57:11 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=9e58d531f93c *** go/types: delete from main repo; part of move to go.exp ...
11 years, 1 month ago (2013-03-12 20:56:02 UTC) #4
minux1
11 years, 1 month ago (2013-03-16 20:00:59 UTC) #5
Message was sent while issue was closed.
https://codereview.appspot.com/7625048/diff/13001/src/make.bash
File src/make.bash (right):

https://codereview.appspot.com/7625048/diff/13001/src/make.bash#newcode143
src/make.bash:143: # TODO: Drop the -tags gotypes before releasing Go 1.1. It is
to allow type checking in go vet.
this should be deleted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b