code review 7625047: go.talks: fix build

go.talks: fix build
Mark those files that should not be compiled by the builder with build tags.
Verified optically that slides are not affected by this.

Fixes issue 4983.

[r, 2013-03-08 23:33:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[iant2, 2013-03-09 00:54:27]

LGTM

On 3/8/13, r@golang.org <r@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks
>
>
> Description:
> go.talks: fix build
> Mark those files that should not be compiled by the builder with build
> tags.
> Verified optically that slides are not affected by this.
>
> Fixes issue 4983.
>
> Please review this at https://codereview.appspot.com/7625047/
>
> Affected files:
>    M 2010/io/balance.go
>    M 2010/io/decrypt.go
>    M 2010/io/encrypt.go
>    M 2010/io/eval1.go
>    M 2010/io/eval2.go
>    M 2012/10things/8.go
>    M 2012/10things/9.go
>    M 2012/10things/9b.go
>    M 2012/insidepresent/socket-simple.go
>    M 2012/insidepresent/socket.go
>    M 2012/insidepresent/websocket.go
>    M 2012/zen/hello.go
>    M 2012/zen/http.go
>    M 2012/zen/jsonformat.go
>    M 2012/zen/race.go
>
>
> Index: 2010/io/balance.go
> ===================================================================
> --- a/2010/io/balance.go
> +++ b/2010/io/balance.go
> @@ -2,6 +2,8 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>   package main
>
>   import (
> Index: 2010/io/decrypt.go
> ===================================================================
> --- a/2010/io/decrypt.go
> +++ b/2010/io/decrypt.go
> @@ -2,6 +2,8 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>   // This code differs from the slides in that it handles errors.
>
>   package main
> Index: 2010/io/encrypt.go
> ===================================================================
> --- a/2010/io/encrypt.go
> +++ b/2010/io/encrypt.go
> @@ -2,6 +2,8 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>   // This code differs from the slides in that it handles errors.
>
>   package main
> Index: 2010/io/eval1.go
> ===================================================================
> --- a/2010/io/eval1.go
> +++ b/2010/io/eval1.go
> @@ -2,6 +2,8 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>   package main
>
>   import (
> Index: 2010/io/eval2.go
> ===================================================================
> --- a/2010/io/eval2.go
> +++ b/2010/io/eval2.go
> @@ -2,6 +2,8 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>   package main
>
>   import (
> Index: 2012/10things/8.go
> ===================================================================
> --- a/2012/10things/8.go
> +++ b/2012/10things/8.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>   package main
>
>   import "fmt"
> Index: 2012/10things/9.go
> ===================================================================
> --- a/2012/10things/9.go
> +++ b/2012/10things/9.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>   package main
>
>   import (
> Index: 2012/10things/9b.go
> ===================================================================
> --- a/2012/10things/9b.go
> +++ b/2012/10things/9b.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>   package main
>
>   import (
> Index: 2012/insidepresent/socket-simple.go
> ===================================================================
> --- a/2012/insidepresent/socket-simple.go
> +++ b/2012/insidepresent/socket-simple.go
> @@ -2,7 +2,7 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> -// +build !appengine
> +// +build !appengine,ignore,OMIT
>
>   package main
>
> Index: 2012/insidepresent/socket.go
> ===================================================================
> --- a/2012/insidepresent/socket.go
> +++ b/2012/insidepresent/socket.go
> @@ -2,7 +2,7 @@
>   // Use of this source code is governed by a BSD-style
>   // license that can be found in the LICENSE file.
>
> -// +build !appengine
> +// +build !appengine,ignore,OMIT
>
>   package main
>
> Index: 2012/insidepresent/websocket.go
> ===================================================================
> --- a/2012/insidepresent/websocket.go
> +++ b/2012/insidepresent/websocket.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>   package main
>
>   import (
> Index: 2012/zen/hello.go
> ===================================================================
> --- a/2012/zen/hello.go
> +++ b/2012/zen/hello.go
> @@ -1,3 +1,4 @@
> +// +build ignore OMIT
>   package main
>
>   import "fmt"
> Index: 2012/zen/http.go
> ===================================================================
> --- a/2012/zen/http.go
> +++ b/2012/zen/http.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>   package main
>
>   import (
> Index: 2012/zen/jsonformat.go
> ===================================================================
> --- a/2012/zen/jsonformat.go
> +++ b/2012/zen/jsonformat.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>   package main
>
>   import ( "encoding/json"; "fmt"; "io"; "os" )
> Index: 2012/zen/race.go
> ===================================================================
> --- a/2012/zen/race.go
> +++ b/2012/zen/race.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>   package main
>
>   import ( "fmt"; "net/http"; "time" )
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[r, 2013-03-09 01:16:04]

*** Submitted as
https://code.google.com/p/go/source/detail?r=07beea0022ac&repo=talks ***

go.talks: fix build
Mark those files that should not be compiled by the builder with build tags.
Verified optically that slides are not affected by this.

Fixes issue 4983.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7625047