Issue 7606044: code review 7606044: net/http: bit more docs on Client vs Transport

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7606044: code review 7606044: net/http: bit more docs on Client vs Transport (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bradfitz

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, adg1

Visibility:
Public.

Description

net/http: bit more docs on Client vs Transport This isn't as bad as it used to be, but add a bit more detail to close the issue. Fixes issue 3359

Patch Set 1 #

Patch Set 2 : diff -r 07986049cf6b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 07986049cf6b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 07986049cf6b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 96b92ad48d10 https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -9 lines)			Patch
M	src/pkg/net/http/client.go	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/pkg/net/http/response.go	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/transport.go	View	1 2 3	4 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2013-03-11 23:46:49 UTC) #1

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-03-11 23:59:58 UTC) #2

bradfitz

(updated to address review feedback via issue tracker) Ready for review again. On Mon, Mar ...

11 years, 2 months ago (2013-03-12 00:02:11 UTC) #3

adg1

LGTM except I think the word is "dechunked" rather than "unchunked". On 12 Mar 2013 ...

11 years, 2 months ago (2013-03-12 00:56:15 UTC) #4

bradfitz

11 years, 2 months ago (2013-03-12 01:51:07 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=ae5a4de1885a ***

net/http: bit more docs on Client vs Transport

This isn't as bad as it used to be, but add a bit
more detail to close the issue.

Fixes issue 3359

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7606044

Expand All Messages | Collapse All Messages