Issue 7579045: code review 7579045: database/sql: fix Conn leak

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7579045: code review 7579045: database/sql: fix Conn leak (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by bradfitz

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, brainman, r, julienschmidt

Visibility:
Public.

Description

database/sql: fix Conn leak Fixes issue 4902

Patch Set 1 #

Patch Set 2 : diff -r 5b76706b55af https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a292c902314 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0a292c902314 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 70d1d0a4bcab https://go.googlecode.com/hg/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	src/pkg/database/sql/sql.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/database/sql/sql_test.go	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 1 month ago (2013-03-08 02:49:54 UTC) #1

brainman

No computers here. Just sand and sea. I will look at it next week when ...

11 years, 1 month ago (2013-03-08 05:05:06 UTC) #2

bradfitz

11 years, 1 month ago (2013-03-08 18:04:12 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3486a9feedda ***

database/sql: fix Conn leak

Fixes issue 4902

R=golang-dev, alex.brainman, r, google
CC=golang-dev
https://codereview.appspot.com/7579045

Expand All Messages | Collapse All Messages