Issue 7572049: code review 7572049: cmd/ld: make hostobj work on newer openbsd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7572049: code review 7572049: cmd/ld: make hostobj work on newer openbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by jsing

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/ld: make hostobj work on newer openbsd Make hostobj work on OpenBSD 5.3/5.4/-current - these have PIE enabled by default and linking fails since the Go linker generates objects that are neither PIC nor PIE. Fixes issue 5067

Patch Set 1 #

Patch Set 2 : diff -r b5b5c246be0c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d2f41f387683 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d2f41f387683 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7e1a4e190b02 https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/cmd/ld/lib.c	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 5 months ago (2013-11-19 15:11:00 UTC) #1

jsing

10 years, 4 months ago (2013-12-19 16:58:41 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=bed0242197b3 ***

cmd/ld: make hostobj work on newer openbsd

Make hostobj work on OpenBSD 5.3/5.4/-current - these have PIE
enabled by default and linking fails since the Go linker generates
objects that are neither PIC nor PIE.

Fixes issue 5067

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7572049

Expand All Messages | Collapse All Messages