Issue 75630043: code review 75630043: go.tools/dashboard/app: send log hash to gobot on build...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75630043: code review 75630043: go.tools/dashboard/app: send log hash to gobot on build... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

go.tools/dashboard/app: send log hash to gobot on build failure Fixes issue 7322.

Patch Set 1 #

Patch Set 2 : diff -r 293a3ab6409d https://code.google.com/p/go.tools #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	dashboard/app/build/notify.go	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 2 months ago (2014-03-13 21:37:21 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=57bd0f2372e7&repo=tools *** go.tools/dashboard/app: send log hash to gobot on build failure Fixes ...

11 years, 2 months ago (2014-03-13 22:51:20 UTC) #3

gobot

11 years, 2 months ago (2014-03-13 23:14:43 UTC) #8

Message was sent while issue was closed.

This CL appears to have broken the testing builder.
See http://build.golang.org/log/quux

Expand All Messages | Collapse All Messages