Issue 7560048: code review 7560048: runtime: pass setmg function to cgo_init

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7560048: code review 7560048: runtime: pass setmg function to cgo_init (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: pass setmg function to cgo_init This keeps the logic about how to set the thread-local variables m and g in code compiled and linked by the gc toolchain, an important property for upcoming cgo changes. It's also just a nice cleanup: one less place to update when these details change.

Patch Set 1 #

Patch Set 2 : diff -r b3cfb8be2faf https://code.google.com/p/go/ #

Patch Set 3 : diff -r b3cfb8be2faf https://code.google.com/p/go/ #

Patch Set 4 : diff -r bcc0898b0026 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -76 lines)			Patch
M	src/pkg/runtime/asm_386.s	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/asm_amd64.s	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_freebsd_386.c	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_freebsd_amd64.c	View	1	2 chunks	+6 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_linux_386.c	View	1	2 chunks	+5 lines, -12 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_linux_amd64.c	View	1	2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_netbsd_386.c	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_netbsd_amd64.c	View	1	2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_openbsd_386.c	View	1	3 chunks	+5 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_openbsd_amd64.c	View	1	3 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-25 21:39:03 UTC) #1

rsc

12 years ago (2013-03-25 22:14:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2bc153c7d415 ***

runtime: pass setmg function to cgo_init

This keeps the logic about how to set the thread-local variables
m and g in code compiled and linked by the gc toolchain,
an important property for upcoming cgo changes.

It's also just a nice cleanup: one less place to update when
these details change.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7560048

Expand All Messages | Collapse All Messages