Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1906)

Issue 7528044: code review 7528044: make.bash,bat: add -tags gotypes to the build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by r
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

make.bash,bat: add -tags gotypes to the build This installs type checking into go vet. (To be removed before releasing Go 1.1)

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r cc7ea3466884 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/make.bash View 1 chunk +4 lines, -2 lines 0 comments Download
M src/make.bat View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-03-06 21:04:40 UTC) #1
minux1
LGTM. https://codereview.appspot.com/7528044/diff/1/src/make.bash File src/make.bash (right): https://codereview.appspot.com/7528044/diff/1/src/make.bash#newcode137 src/make.bash:137: # TODO: Drop the -tags gotypes before releasing ...
11 years, 1 month ago (2013-03-06 21:09:21 UTC) #2
r
I thought of that but go/types is likely to move to a separate repo (go.exp) ...
11 years, 1 month ago (2013-03-06 21:16:27 UTC) #3
r
11 years, 1 month ago (2013-03-06 21:16:45 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=3beef801220b ***

make.bash,bat: add -tags gotypes to the build
This installs type checking into go vet.
(To be removed before releasing Go 1.1)

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7528044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b