Issue 75260043: code review 75260043: runtime: detect stack split after fork

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75260043: code review 75260043: runtime: detect stack split after fork (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dvyukov

Modified:
10 years, 1 month ago

Reviewers:
rsc

CC:
rsc, aram, golang-codereviews

Visibility:
Public.

Description

runtime: detect stack split after fork This check would allowed to easily prevent issue 7511. Update issue 7511

Patch Set 1 #

Patch Set 2 : diff -r d115d6b9aaa2 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r ceb13960d05b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ceb13960d05b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r ceb13960d05b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r ceb13960d05b https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	src/pkg/runtime/proc.c	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/stack.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 1 month ago (2014-03-13 12:25:19 UTC) #1

dvyukov

10 years, 1 month ago (2014-03-13 13:41:15 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c6514f31d45a ***

runtime: detect stack split after fork
This check would allowed to easily prevent issue 7511.
Update issue 7511

LGTM=rsc
R=rsc, aram
CC=golang-codereviews
https://codereview.appspot.com/75260043

Expand All Messages | Collapse All Messages