Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5037)

Issue 75180043: code review 75180043: net: improve behavior of native Go DNS queries

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by axaxs
Modified:
9 years, 10 months ago
Visibility:
Public.

Description

net: improve behavior of native Go DNS queries See https://groups.google.com/forum/#!topic/golang-dev/lV-0aHqxVeo Fixes issue 6579. Benchmark results on linux/amd64: benchmark old ns/op new ns/op delta BenchmarkGoLookupIP 59284398 35349632 -40.37% BenchmarkGoLookupIPNoSuchHost 131102584 34241062 -73.88% BenchmarkGoLookupIPWithBrokenNameServer 20048604097 5024381059 -74.94% benchmark old allocs new allocs delta BenchmarkGoLookupIP 107 112 4.67% BenchmarkGoLookupIPNoSuchHost 212 110 -48.11% BenchmarkGoLookupIPWithBrokenNameServer 165 161 -2.42% benchmark old bytes new bytes delta BenchmarkGoLookupIP 11416 11863 3.92% BenchmarkGoLookupIPNoSuchHost 23331 12053 -48.34% BenchmarkGoLookupIPWithBrokenNameServer 25696 21728 -15.44%

Patch Set 1 #

Patch Set 2 : diff -r 8a975cf68c20 https://code.google.com/p/go #

Patch Set 3 : diff -r 8a975cf68c20 https://code.google.com/p/go #

Patch Set 4 : diff -r 8a975cf68c20 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -102 lines) Patch
M src/pkg/net/dnsclient_unix.go View 1 2 6 chunks +93 lines, -102 lines 0 comments Download
M src/pkg/net/dnsclient_unix_test.go View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3
axaxs
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 1 month ago (2014-03-15 02:25:04 UTC) #1
gobot
R=mikioh.mikioh@gmail.com (assigned by josharian@gmail.com)
10 years, 1 month ago (2014-03-15 14:40:37 UTC) #2
rsc
10 years ago (2014-04-17 02:57:32 UTC) #3
R=close

Thanks for working on this. I'm sorry, but the release freeze was March 1.
Please run 'hg mail' once Go 1.3 is out and we can pick this up for 1.4. The
improvements do look impressive.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b