Issue 7510048: code review 7510048: all.bat,make.bat,run.bat: make these work even when dir...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7510048: code review 7510048: all.bat,make.bat,run.bat: make these work even when dir... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by brainman

Modified:
12 years ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

all.bat,make.bat,run.bat: make these work even when directory has space in it

Patch Set 1 #

Patch Set 2 : diff -r 4c03cdfdff50 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4c03cdfdff50 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4c03cdfdff50 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/all.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/make.bat	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/run.bat	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-25 01:08:43 UTC) #1

bradfitz

LGTM On Mar 24, 2013 6:08 PM, <alex.brainman@gmail.com> wrote: > Reviewers: golang-dev1, > > Message: ...

12 years ago (2013-03-25 01:11:58 UTC) #2

LGTM
 On Mar 24, 2013 6:08 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> all.bat,make.bat,run.bat: make these work even when directory has space
> in it
>
> Please review this at
https://codereview.appspot.**com/7510048/<https://codereview.appspot.com/7510...
>
> Affected files:
>   M src/all.bat
>   M src/make.bat
>   M src/run.bat
>
>
> Index: src/all.bat
> ==============================**==============================**=======
> --- a/src/all.bat
> +++ b/src/all.bat
> @@ -20,7 +20,7 @@
>  :: can get the original %PATH% and give suggestion to add %GOROOT%/bin
>  :: to %PATH% if necessary.
>  set PATH=%OLDPATH%
> -%GOTOOLDIR%/dist banner
> +"%GOTOOLDIR%/dist" banner
>
>  :end
>  if x%GOBUILDEXIT%==x1 exit %GOBUILDFAIL%
> Index: src/make.bat
> ==============================**==============================**=======
> --- a/src/make.bat
> +++ b/src/make.bat
> @@ -109,8 +109,8 @@
>  goto end
>
>  :copydist
> -mkdir %GOTOOLDIR% 2>NUL
> -copy cmd\dist\dist.exe %GOTOOLDIR%\
> +mkdir "%GOTOOLDIR%" 2>NUL
> +copy cmd\dist\dist.exe "%GOTOOLDIR%\"
>  goto end
>
>  :fail
> Index: src/run.bat
> ==============================**==============================**=======
> --- a/src/run.bat
> +++ b/src/run.bat
> @@ -74,12 +74,12 @@
>  :: cgo tests
>  if x%CGO_ENABLED% == x0 goto nocgo
>  echo # ..\misc\cgo\life
> -go run %GOROOT%\test\run.go - ..\misc\cgo\life
> +go run "%GOROOT%\test\run.go" - ..\misc\cgo\life
>  if errorlevel 1 goto fail
>  echo.
>
>  echo # ..\misc\cgo\stdio
> -go run %GOROOT%\test\run.go - ..\misc\cgo\stdio
> +go run "%GOROOT%\test\run.go" - ..\misc\cgo\stdio
>  if errorlevel 1 goto fail
>  echo.
>
> @@ -90,7 +90,7 @@
>  :nocgo
>
>  echo # ..\doc\progs
> -go run %GOROOT%\test\run.go - ..\doc\progs
> +go run "%GOROOT%\test\run.go" - ..\doc\progs
>  if errorlevel 1 goto fail
>  echo.
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

brainman

12 years ago (2013-03-25 01:13:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ac5c65136f42 ***

all.bat,make.bat,run.bat: make these work even when directory has space in it

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7510048

Expand All Messages | Collapse All Messages