Issue 7508043: code review 7508043: net/http: remove allocations in HeaderWriteSubset

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7508043: code review 7508043: net/http: remove allocations in HeaderWriteSubset (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bradfitz

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http: remove allocations in HeaderWriteSubset Before: BenchmarkHeaderWriteSubset 500000 2354 ns/op 197 B/op 2 allocs/op After: BenchmarkHeaderWriteSubset 1000000 2085 ns/op 0 B/op 0 allocs/op Fixes issue 3761

Patch Set 1 #

Patch Set 2 : diff -r 91db139d15e5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 91db139d15e5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ca2b2e58fb69 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ca2b2e58fb69 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 011944857f1f https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -13 lines)			Patch
	M	src/pkg/net/http/header.go	View	1 2 3 4	3 chunks	+34 lines, -9 lines	0 comments	Download
	M	src/pkg/net/http/header_test.go	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2013-03-06 15:52:36 UTC) #1

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 1 month ago (2013-03-06 21:58:12 UTC) #3

bradfitz

I simplified it more, removing the self-referencing sort.Interface. I realized it's unnecessary once I'm using ...

12 years, 1 month ago (2013-03-06 21:59:21 UTC) #4

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 1 month ago (2013-03-06 22:02:22 UTC) #5

bradfitz

12 years, 1 month ago (2013-03-06 22:10:50 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=622045a2f25a ***

net/http: remove allocations in HeaderWriteSubset

Before:
BenchmarkHeaderWriteSubset  500000  2354 ns/op  197 B/op  2 allocs/op
After:
BenchmarkHeaderWriteSubset 1000000  2085 ns/op    0 B/op  0 allocs/op

Fixes issue 3761

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7508043

Expand All Messages | Collapse All Messages