code review 7474043: go/types: fix handling of string(rune lit) constants.

go/types: fix handling of string(rune lit) constants.

Fixes issue 4982.

[remyoudompheng, 2013-03-05 08:11:30]

Hello gri@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[albert.strasheim, 2013-03-05 08:18:03]

LGTM

[gri, 2013-03-05 17:52:05]

The correct fix is to implement conversions for constants, which is not done
yet. This is a - somewhat surprising, I must admit - work-around.

Please abandon this CL.

I'll try to get to this soon.
Thanks.

https://codereview.appspot.com/7474043/diff/5001/src/pkg/go/types/const.go
File src/pkg/go/types/const.go (right):

https://codereview.appspot.com/7474043/diff/5001/src/pkg/go/types/const.go#ne...
src/pkg/go/types/const.go:343: case string:
This is not the right fix, even though it seems to work. First of all, x and y
are not of the same kind in this case (which is a prerequisite) and just
"fixing" it here is not right. (the cases on line 340 should probably assert the
right type of y to catch this).

matchConst shouldn't do conversions.

https://codereview.appspot.com/7474043/diff/5001/src/pkg/go/types/testdata/co...
File src/pkg/go/types/testdata/const0.src (right):

https://codereview.appspot.com/7474043/diff/5001/src/pkg/go/types/testdata/co...
src/pkg/go/types/testdata/const0.src:35: ui10 = 1 / 0     /* ERROR "division by
zero" */
In general, these files are not gofmt-ed because the comments are
position-sensitive and gofmt may move them around. Please just leave it alone.

[remyoudompheng, 2013-03-05 21:43:11]

*** Abandoned ***