Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 7469043: code review 7469043: image/jpeg: for progressive JPEGs, the first SOS segmen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by nigeltao
Modified:
12 years ago
Reviewers:
CC:
r, minux1, bradfitz, golang-dev
Visibility:
Public.

Description

image/jpeg: for progressive JPEGs, the first SOS segment doesn't necessarily contain all components. Fixes issue 4975.

Patch Set 1 #

Patch Set 2 : diff -r eb28a75cdc40 https://code.google.com/p/go/ #

Patch Set 3 : diff -r eb28a75cdc40 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 228a4fbc0f66 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/image/jpeg/scan.go View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-03-05 03:23:17 UTC) #1
r
LGTM
12 years ago (2013-03-05 15:45:00 UTC) #2
minux1
tests?
12 years ago (2013-03-05 16:09:50 UTC) #3
bradfitz
On Tue, Mar 5, 2013 at 8:09 AM, minux <minux.ma@gmail.com> wrote: > tests? Presumably the ...
12 years ago (2013-03-05 16:12:59 UTC) #4
minux1
On Wed, Mar 6, 2013 at 12:12 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > On Tue, Mar ...
12 years ago (2013-03-05 16:16:20 UTC) #5
nigeltao
12 years ago (2013-03-05 23:09:09 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=91db139d15e5 ***

image/jpeg: for progressive JPEGs, the first SOS segment doesn't
necessarily contain all components.

Fixes issue 4975.

R=r, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7469043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b