Issue 7469043: code review 7469043: image/jpeg: for progressive JPEGs, the first SOS segmen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7469043: code review 7469043: image/jpeg: for progressive JPEGs, the first SOS segmen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by nigeltao

Modified:
12 years ago

Reviewers:

CC:
r, minux1, bradfitz, golang-dev

Visibility:
Public.

Description

image/jpeg: for progressive JPEGs, the first SOS segment doesn't necessarily contain all components. Fixes issue 4975.

Patch Set 1 #

Patch Set 2 : diff -r eb28a75cdc40 https://code.google.com/p/go/ #

Patch Set 3 : diff -r eb28a75cdc40 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 228a4fbc0f66 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/pkg/image/jpeg/scan.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-05 03:23:17 UTC) #1

bradfitz

On Tue, Mar 5, 2013 at 8:09 AM, minux <minux.ma@gmail.com> wrote: > tests? Presumably the ...

12 years ago (2013-03-05 16:12:59 UTC) #4

minux1

On Wed, Mar 6, 2013 at 12:12 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > On Tue, Mar ...

12 years ago (2013-03-05 16:16:20 UTC) #5

nigeltao

12 years ago (2013-03-05 23:09:09 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=91db139d15e5 ***

image/jpeg: for progressive JPEGs, the first SOS segment doesn't
necessarily contain all components.

Fixes issue 4975.

R=r, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7469043

Expand All Messages | Collapse All Messages