code review 7456049: net: make TestConnAndListener less flaky

net: make some tests less flaky

Fixes issue 4969

[bradfitz, 2013-03-04 17:23:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-03-04 18:28:26]

given that I couldn't make test TestTCPConnSpecificMethods pass
on the netbsd/arm builder (see
http://build.golang.org/log/67d1c8aec152c5d1c23923fba2aa8f254ff3f83b),
could you please do the same to ~line 108 of protoconn_test.go?

[bradfitz, 2013-03-04 19:14:33]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-03-04 19:14:40]

On Mon, Mar 4, 2013 at 10:28 AM, <minux.ma@gmail.com> wrote:

> given that I couldn't make test TestTCPConnSpecificMethods pass
> on the netbsd/arm builder (see
>
http://build.golang.org/log/**67d1c8aec152c5d1c23923fba2aa8f**254ff3f83b<http...
> ),
> could you please do the same to ~line 108 of protoconn_test.go?
>

done

[minux1, 2013-03-04 19:44:59]

LGTM.

Please make the description more general, perhaps
just "net: make non-timeout tests less flaky".

[minux1, 2013-03-04 19:46:39]

On Tue, Mar 5, 2013 at 3:14 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> On Mon, Mar 4, 2013 at 10:28 AM, <minux.ma@gmail.com> wrote:
>> given that I couldn't make test TestTCPConnSpecificMethods pass
>> on the netbsd/arm builder (see
>> http://build.golang.org/log/67d1c8aec152c5d1c23923fba2aa8f254ff3f83b),
>> could you please do the same to ~line 108 of protoconn_test.go?
> done
Thank you!

[bradfitz, 2013-03-04 19:55:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=e39b9fa789ca ***

net: make some tests less flaky

Fixes issue 4969

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7456049

[mikio, 2013-03-04 23:48:45]

phew, thanks.
did i make a crosstalk situation by deadlines?

[minux1, 2013-03-04 23:50:25]

On Tue, Mar 5, 2013 at 7:48 AM,  <mikioh.mikioh@gmail.com> wrote:
> phew, thanks.
> did i make a crosstalk situation by deadlines?
no, it's just some builders are really slow.