Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(322)

Issue 7453048: code review 7453048: misc/dashboard/builder: make -fail mode faster (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

misc/dashboard/builder: make -fail mode faster Don't check out the repository if we're just going to fail everything.

Patch Set 1 #

Patch Set 2 : diff -r 67fc3cb0d3aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 67fc3cb0d3aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f68236592c6a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/dashboard/builder/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-03-04 15:02:37 UTC) #1
bradfitz
LGTM On Mon, Mar 4, 2013 at 7:02 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
12 years ago (2013-03-04 15:10:53 UTC) #2
rsc
12 years ago (2013-03-04 15:31:04 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=41f1421cecd1 ***

misc/dashboard/builder: make -fail mode faster

Don't check out the repository if we're just going to fail everything.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7453048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b