Issue 7445046: code review 7445046: net: skip interface tests when required external comman...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7445046: code review 7445046: net: skip interface tests when required external comman... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by mikio

Modified:
11 years, 1 month ago

Reviewers:

CC:
brainman, golang-dev

Visibility:
Public.

Description

net: skip interface tests when required external command not found Fixes issue 4952.

Patch Set 1 #

Patch Set 2 : diff -r 1b4b6a694b1c https://code.google.com/p/go #

Patch Set 3 : diff -r 1b4b6a694b1c https://code.google.com/p/go #

Patch Set 4 : diff -r 17a869d2ae24 https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	src/pkg/net/interface_bsd_test.go	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/pkg/net/interface_linux_test.go	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/pkg/net/interface_unix_test.go	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2013-03-01 07:56:48 UTC) #1

mikio

11 years, 1 month ago (2013-03-02 01:56:58 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6883846dfe42 ***

net: skip interface tests when required external command not found

Fixes issue 4952.

R=alex.brainman
CC=golang-dev
https://codereview.appspot.com/7445046

Expand All Messages | Collapse All Messages