code review 7443052: go.talks/pkg/present: remove tilde from bad url chars

go.talks/pkg/present: remove tilde from bad url chars

Obviously we should be able to use tilde in URLs.

[adg, 2013-03-04 06:06:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[minux1, 2013-03-04 08:55:15]

LGTM.

[r, 2013-03-04 15:47:17]

the cited RFC says don't use ~, so explain yourself please.

-rob

[minux1, 2013-03-04 15:54:16]

On Mon, Mar 4, 2013 at 11:47 PM, Rob Pike <r@golang.org> wrote:

> the cited RFC says don't use ~, so explain yourself please.
>
'~' is unsafe in URL, but i believe its use is pretty common in URLs, for
example,
per-user web directories: host/~user/
(e.g.: http://httpd.apache.org/docs/2.2/howto/public_html.html)

[r, 2013-03-04 16:41:32]

I understand why you want it but the RFC excludes it so you need to explain
in the code why it decides differently.

-rob
On Mar 4, 2013 7:54 AM, "minux" <minux.ma@gmail.com> wrote:

>
> On Mon, Mar 4, 2013 at 11:47 PM, Rob Pike <r@golang.org> wrote:
>
>> the cited RFC says don't use ~, so explain yourself please.
>>
> '~' is unsafe in URL, but i believe its use is pretty common in URLs, for
> example,
> per-user web directories: host/~user/
> (e.g.: http://httpd.apache.org/docs/2.2/howto/public_html.html)
>

[npe, 2013-03-04 17:07:37]

I can't speak for Andrew but I think the tilde is now legal:

http://www.cs.tut.fi/~jkorpela/rfc/2396/full.html#2.3 (see G.2)

It may just be a matter of changing the comment.

Noah


On Mon, Mar 4, 2013 at 5:41 PM, Rob Pike <r@golang.org> wrote:
> I understand why you want it but the RFC excludes it so you need to explain
> in the code why it decides differently.
>
> -rob
>
> On Mar 4, 2013 7:54 AM, "minux" <minux.ma@gmail.com> wrote:
>>
>>
>> On Mon, Mar 4, 2013 at 11:47 PM, Rob Pike <r@golang.org> wrote:
>>>
>>> the cited RFC says don't use ~, so explain yourself please.
>>
>> '~' is unsafe in URL, but i believe its use is pretty common in URLs, for
>> example,
>> per-user web directories: host/~user/
>> (e.g.: http://httpd.apache.org/docs/2.2/howto/public_html.html)
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[adg, 2013-03-05 03:53:09]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, r@golang.org,
noah.evans@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2013-03-05 03:53:48]

Updated to refer to the newer RFC, which lists the same character set I
have used here.


On 5 March 2013 03:41, Rob Pike <r@golang.org> wrote:

> I understand why you want it but the RFC excludes it so you need to
> explain in the code why it decides differently.
>
> -rob
> On Mar 4, 2013 7:54 AM, "minux" <minux.ma@gmail.com> wrote:
>
>>
>> On Mon, Mar 4, 2013 at 11:47 PM, Rob Pike <r@golang.org> wrote:
>>
>>> the cited RFC says don't use ~, so explain yourself please.
>>>
>> '~' is unsafe in URL, but i believe its use is pretty common in URLs, for
>> example,
>> per-user web directories: host/~user/
>> (e.g.: http://httpd.apache.org/docs/2.2/howto/public_html.html)
>>
>

[r, 2013-03-05 07:08:09]

LGTM

[adg, 2013-03-05 23:07:32]

*** Submitted as
https://code.google.com/p/go/source/detail?r=213dad46253b&repo=talks ***

go.talks/pkg/present: remove tilde from bad url chars

Obviously we should be able to use tilde in URLs.

R=golang-dev, minux.ma, r, noah.evans
CC=golang-dev
https://codereview.appspot.com/7443052